Re: [PATCH net-next] can: kvaser_pciefd: Remove unused macro KVASER_PCIEFD_KCAN_CTRL_EFRAME

From: Marc Kleine-Budde
Date: Tue Sep 15 2020 - 02:31:42 EST


On 9/4/20 3:10 PM, Wang Hai wrote:
> KVASER_PCIEFD_KCAN_CTRL_EFRAME is never used after it was introduced.
> So better to remove it.
>
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Wang Hai <wanghai38@xxxxxxxxxx>
> ---
> drivers/net/can/kvaser_pciefd.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/can/kvaser_pciefd.c b/drivers/net/can/kvaser_pciefd.c
> index 6f766918211a..c0b18ff107c7 100644
> --- a/drivers/net/can/kvaser_pciefd.c
> +++ b/drivers/net/can/kvaser_pciefd.c
> @@ -131,7 +131,6 @@ MODULE_DESCRIPTION("CAN driver for Kvaser CAN/PCIe devices");
>
> /* Kvaser KCAN definitions */
> #define KVASER_PCIEFD_KCAN_CTRL_EFLUSH (4 << 29)
> -#define KVASER_PCIEFD_KCAN_CTRL_EFRAME (5 << 29)
>
> #define KVASER_PCIEFD_KCAN_CMD_SEQ_SHIFT 16
> /* Request status packet */
>

I'd like to keep this for documentation purpose, too.

Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

Attachment: signature.asc
Description: OpenPGP digital signature