Re: [PATCH v12 00/14] mtd: spi-nor: add xSPI Octal DTR support

[Vignesh Raghavendra]

On 9/3/20 10:42 PM, Pratyush Yadav wrote:
> Hi,
> 
> This series adds support for Octal DTR flashes in the SPI NOR framework,
> and then adds hooks for the Cypress Semper and Micron Xcella flashes to
> allow running them in Octal DTR mode. This series assumes that the flash
> is handed to the kernel in Legacy SPI mode.
> 
> Tested on TI J721E EVM with 1-bit ECC on the Cypress flash.
> 
[...]

Please fix checkpatch issues on patch 1, 3, 4 and 5

Otherwise patches look good to me...

> 
> Pratyush Yadav (14):
>   mtd: spi-nor: core: add spi_nor_{read,write}_reg() helpers
>   mtd: spi-nor: core: add spi_nor_controller_ops_erase helper
>   mtd: spi-nor: add support for DTR protocol
>   mtd: spi-nor: sfdp: get command opcode extension type from BFPT
>   mtd: spi-nor: sfdp: parse xSPI Profile 1.0 table
>   mtd: spi-nor: core: use dummy cycle and address width info from SFDP
>   mtd: spi-nor: core: do 2 byte reads for SR and FSR in DTR mode
>   mtd: spi-nor: core: enable octal DTR mode when possible
>   mtd: spi-nor: sfdp: detect Soft Reset sequence support from BFPT
>   mtd: spi-nor: core: perform a Soft Reset on shutdown
>   mtd: spi-nor: core: disable Octal DTR mode on suspend.
>   mtd: spi-nor: core: expose spi_nor_default_setup() in core.h
>   mtd: spi-nor: spansion: add support for Cypress Semper flash
>   mtd: spi-nor: micron-st: allow using MT35XU512ABA in Octal DTR mode
> 
>  drivers/mtd/spi-nor/core.c      | 462 ++++++++++++++++++++++++--------
>  drivers/mtd/spi-nor/core.h      |  23 ++
>  drivers/mtd/spi-nor/micron-st.c | 102 ++++++-
>  drivers/mtd/spi-nor/sfdp.c      | 122 ++++++++-
>  drivers/mtd/spi-nor/sfdp.h      |   8 +
>  drivers/mtd/spi-nor/spansion.c  | 166 ++++++++++++
>  include/linux/mtd/spi-nor.h     |  53 +++-
>  7 files changed, 813 insertions(+), 123 deletions(-)