Re: [PATCH RFC 6/7] bridge: cfm: Netlink Notifications.

From: henrik.bjoernlund@xxxxxxxxxxxxx
Date: Tue Sep 15 2020 - 06:27:17 EST


Thanks for the review. Comments below.

The 09/08/2020 13:54, Nikolay Aleksandrov wrote:
>
> On Fri, 2020-09-04 at 09:15 +0000, Henrik Bjoernlund wrote:
> > This is the implementation of Netlink notifications out of CFM.
> >
> > Notifications are initiated whenever a state change happens in CFM.
> >
> [snip]
> > + *count = 0;
> > +
> > + rcu_read_lock();
> > + list_for_each_entry_rcu(mep, &br->mep_list, head)
> > + * count += 1;
>
> please remove the extra space
>
I have removed the extra space.
This space was added to satify checkpatch as without this space it gives
this error:
CHECK: spaces preferred around that '*' (ctx:ExV)
#136: FILE: net/bridge/br_cfm.c:883:
+ *count += 1;
^

> > + rcu_read_unlock();
> > +
> > + return 0;
> > +}
> > +
>
>

--
/Henrik