Re: [PATCH 1/2] printk: ringbuffer: fix setting state in desc_read()

From: Petr Mladek
Date: Tue Sep 15 2020 - 12:19:04 EST


On Mon 2020-09-14 11:54:02, John Ogness wrote:
> It is expected that desc_read() will always set at least the
> @state_var field. However, if the descriptor is in an inconsistent
> state, no fields are set.
>
> Also, the second load of @state_var is not stored in @desc_out and
> so might not match the state value that is returned.
>
> Always set the last loaded @state_var into @desc_out, regardless of
> the descriptor consistency.
>
> Fixes: b6cf8b3f3312 ("printk: add lockless ringbuffer")
> Signed-off-by: John Ogness <john.ogness@xxxxxxxxxxxxx>

Both patches are committed into printk/linux.git, branch printk-rework.

Best Regards,
Petr