Re: [PATCH] arch: x86: power: cpu: init %gs before __restore_processor_state (clang)

From: Roman Kiryanov
Date: Tue Sep 15 2020 - 14:36:59 EST


On Tue, Sep 15, 2020 at 11:27 AM Borislav Petkov <bp@xxxxxxxxx> wrote:
> > I believe the kernel makes a questionable assumption on how clang
> > uses registers (gs will not be used if stack protection is disabled).
> > Both kernel and clang behaves unfortunate here.
>
> If the kernel is at fault here and this same thing happens with GCC,
> sure, but this is a clang-specific fix.

This is fair. Unfortunately I am not an x86 asm expert. I expect the proper
fix should land into arch/x86/kernel/acpi/wakeup_64.S to init %gs
(maybe some more registers) before "jmp restore_processor_state".

Regards,
Roman.