Re: [PATCH V3 1/2] dt-bindings: mailbox : arm,mhu: Convert to Json-schema

From: Rob Herring
Date: Tue Sep 15 2020 - 18:49:44 EST


On Tue, Sep 15, 2020 at 1:49 PM Jassi Brar <jassisinghbrar@xxxxxxxxx> wrote:
>
> On Tue, Sep 15, 2020 at 2:35 PM Rob Herring <robh@xxxxxxxxxx> wrote:
> >
> > On Thu, Sep 10, 2020 at 03:25:18PM +0530, Viresh Kumar wrote:
> > > Convert the DT binding over to Json-schema.
> > >
> > > Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
> > > ---
> > > V3: New patch.
> > >
> > > .../devicetree/bindings/mailbox/arm,mhu.yaml | 86 +++++++++++++++++++
> > > .../devicetree/bindings/mailbox/arm-mhu.txt | 43 ----------
> > > 2 files changed, 86 insertions(+), 43 deletions(-)
> > > create mode 100644 Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
> > > delete mode 100644 Documentation/devicetree/bindings/mailbox/arm-mhu.txt
> > >
> > > diff --git a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
> > > new file mode 100644
> > > index 000000000000..4e840cedb2e4
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml
> > > @@ -0,0 +1,86 @@
> > > +# SPDX-License-Identifier: GPL-2.0
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/mailbox/arm,mhu.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: ARM MHU Mailbox Controller
> > > +
> > > +maintainers:
> > > + - Jassi Brar <jaswinder.singh@xxxxxxxxxx>
> >
> > Ideally, this should be someone familiar with the h/w, not the subsystem
> > maintainer. Sudeep or you in this case?
> >
> If you are ok with the content of this file, maybe I am not as
> unfamiliar with MHU as you think :D I wrote the original doc/binding
> that this yaml is translated from.

You're right, I'd already forgotten this comment when I checked for
licensing afterwards and saw you wrote it. It's just a common thing
I'm commenting on.

> Maybe Viresh/Sudeep should be the maintainer of the mhu doorbell bindings ?

I'm sure at this point, no one does. :)

Rob