Re: [PATCH v4] mm/vmscan: add a fatal signals check in drop_slab_node

[Michal Hocko]

On Tue 15-09-20 15:47:37, Chris Down wrote:
> zangchunxin@xxxxxxxxxxxxx writes:
> > +		if (signal_pending(current))
> > +			return;
> 
> This doesn't match your patch title, please update it. :-)

I have to admit I have completely missed this and I think that this
should better be fatal_signal_pending because that would make sure that
the userspace will not see an incomplete operation. This is a general
practice for other bail outs as well.

> After that, you can add:
> 
> Acked-by: Chris Down <chris@xxxxxxxxxxxxxx>

-- 
Michal Hocko
SUSE Labs