Re: [PATCH net-next 1/3] ethtool: Add 100base-FX link mode entries

[Dan Murphy]

Andrew

On 9/15/20 3:21 PM, Andrew Lunn wrote:
> On Tue, Sep 15, 2020 at 01:17:06PM -0500, Dan Murphy wrote:
> > Add entries for the 100base-FX full and half duplex supported modes.
> >
> > $ ethtool eth0
> >          Supported ports: [ TP    MII     FIBRE ]
> >          Supported link modes:   10baseT/Half 10baseT/Full
> >                                  100baseT/Half 100baseT/Full
> >                                  100baseFX/Half 100baseFX/Full
> >          Supported pause frame use: Symmetric Receive-only
> >          Supports auto-negotiation: No
> >          Supported FEC modes: Not reported
> >          Advertised link modes:  10baseT/Half 10baseT/Full
> >                                  100baseT/Half 100baseT/Full
> >                                  100baseFX/Half 100baseFX/Full
> I thought this PHY could not switch between TP and Fibre. It has a
> strap which decides? So i would expect the supported modes to be
> either BaseT or BaseFX. Not both. Same for Advertised?
>
>         Andrew

I found that the phy-device was setting all these bits in phy_init in 
features_init.

My first pass was to clear all these bits as well because the PHY was 
still advertising these modes.

But you are right this PHY cannot switch without strapping.

I can clear these bits.

Dan