Re: [PATCH] mm/page_alloc.c: variable type of 'progress' should be 'unsigned long'

From: Xu, Yanfei
Date: Tue Sep 15 2020 - 21:57:02 EST




On 9/16/20 8:48 AM, Andrew Morton wrote:
On Tue, 15 Sep 2020 18:46:20 +0800 <yanfei.xu@xxxxxxxxxxxxx> wrote:

From: Yanfei Xu <yanfei.xu@xxxxxxxxxxxxx>

try_to_free_pages returns the number of pages reclaimed, and the type of
returns is 'unsigned long'. So we should use a matched type for storing
it.


__perform_reclaim() returns an int, so this change is fairly pointless.

However __perform_reclaim()'s single caller expects it to return
unsigned long, so including that change in this patch would make more
sense.

Yeah, thanks for reminding. I will add that and send a v2. :)

Regards,
Yanfei