Re: [PATCH] reiserfs: only call unlock_new_inode() if I_NEW

From: Eric Biggers
Date: Wed Sep 16 2020 - 00:01:25 EST


On Mon, Jul 27, 2020 at 09:52:15AM -0700, Eric Biggers wrote:
> On Sun, Jun 28, 2020 at 12:00:57AM -0700, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@xxxxxxxxxx>
> >
> > unlock_new_inode() is only meant to be called after a new inode has
> > already been inserted into the hash table. But reiserfs_new_inode() can
> > call it even before it has inserted the inode, triggering the WARNING in
> > unlock_new_inode(). Fix this by only calling unlock_new_inode() if the
> > inode has the I_NEW flag set, indicating that it's in the table.
> >
> > This addresses the syzbot report "WARNING in unlock_new_inode"
> > (https://syzkaller.appspot.com/bug?extid=187510916eb6a14598f7).
> >
> > Reported-by: syzbot+187510916eb6a14598f7@xxxxxxxxxxxxxxxxxxxxxxxxx
> > Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>
>
> Anyone interested in taking this patch?

Jan, you seem to be taking some reiserfs patches... Any interest in taking this
one?

- Eric