Re: [PATCH] soundwire: Add generic bandwidth allocation algorithm

From: Jaroslav Kysela
Date: Wed Sep 16 2020 - 04:30:15 EST


Dne 09. 09. 20 v 8:26 Jaroslav Kysela napsal(a):
> Dne 08. 09. 20 v 15:15 Bard Liao napsal(a):
>> This algorithm computes bus parameters like clock frequency, frame
>> shape and port transport parameters based on active stream(s) running
>> on the bus.
>>
>> Developers can also implement their own .compute_params() callback for
>> specific resource management algorithm, and set if before calling
>> sdw_add_bus_master()
>>
>> Credits: this patch is based on an earlier internal contribution by
>> Vinod Koul, Sanyog Kale, Shreyas Nc and Hardik Shah. All hard-coded
>> values were removed from the initial contribution to use BIOS
>> information instead.
>>
>> Signed-off-by: Bard Liao <yung-chuan.liao@xxxxxxxxxxxxxxx>
>> ---
>> drivers/soundwire/Kconfig | 5 +
>> drivers/soundwire/Makefile | 3 +
>> drivers/soundwire/bus.c | 6 +
>> drivers/soundwire/bus.h | 46 +-
>> .../soundwire/generic_bandwidth_allocation.c | 427 ++++++++++++++++++
>> drivers/soundwire/intel.c | 3 +
>> drivers/soundwire/stream.c | 12 +
>> include/linux/soundwire/sdw.h | 3 +
>> 8 files changed, 503 insertions(+), 2 deletions(-)
>> create mode 100644 drivers/soundwire/generic_bandwidth_allocation.c
>
> I did testing and I've not found any issues. The abstraction looks good.
>
> Acked-by: Jaroslav Kysela <perex@xxxxxxxx>
>

Vinod, ping.... This is the last patch which is missing to get the soundwire
audio working on some Intel hardware platforms (laptops) which are already on
the market.

Thank you,
Jaroslav

--
Jaroslav Kysela <perex@xxxxxxxx>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.