RE: [EXT] [PATCH -next] scsi: bnx2i: remove unnecessary mutex_init()

[Manish Rangankar]

> -----Original Message-----
> From: Qinglang Miao <miaoqinglang@xxxxxxxxxx>
> Sent: Wednesday, September 16, 2020 11:52 AM
> To: Nilesh Javali <njavali@xxxxxxxxxxx>; Manish Rangankar
> <mrangankar@xxxxxxxxxxx>; GR-QLogic-Storage-Upstream <GR-QLogic-
> Storage-Upstream@xxxxxxxxxxx>; James E.J. Bottomley
> <jejb@xxxxxxxxxxxxx>; Martin K. Petersen <martin.petersen@xxxxxxxxxx>
> Cc: linux-scsi@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Qinglang Miao
> <miaoqinglang@xxxxxxxxxx>
> Subject: [EXT] [PATCH -next] scsi: bnx2i: remove unnecessary mutex_init()
> 
> External Email
> 
> ----------------------------------------------------------------------
> The mutex bnx2i_dev_lock is initialized statically. It is unnecessary to
> initialize by mutex_init().
> 
> Signed-off-by: Qinglang Miao <miaoqinglang@xxxxxxxxxx>
> ---
>  drivers/scsi/bnx2i/bnx2i_init.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/scsi/bnx2i/bnx2i_init.c b/drivers/scsi/bnx2i/bnx2i_init.c
> index 6018cdd17..2b3f0c104 100644
> --- a/drivers/scsi/bnx2i/bnx2i_init.c
> +++ b/drivers/scsi/bnx2i/bnx2i_init.c
> @@ -474,8 +474,6 @@ static int __init bnx2i_mod_init(void)
>  	if (sq_size && !is_power_of_2(sq_size))
>  		sq_size = roundup_pow_of_two(sq_size);
> 
> -	mutex_init(&bnx2i_dev_lock);
> -
>  	bnx2i_scsi_xport_template =
>  			iscsi_register_transport(&bnx2i_iscsi_transport);
>  	if (!bnx2i_scsi_xport_template) {
> --

Thanks,
Acked-by: Manish Rangankar <mrangankar@xxxxxxxxxxx>