Re: [PATCH v5 0/3] arm: dts: add and modify device node in NPCM7xx device tree

[Joel Stanley]

Hi Tomer,

On Wed, 16 Sep 2020 at 12:56, Tomer Maimon <tmaimon77@xxxxxxxxx> wrote:
>
> This patch set adds and modify device tree nodes in the NPCM7xx
> Baseboard Management Controller (BMC) device tree.

Thanks Tomer. I smoke tested these by booting on the npcm730 qemu
machine. Are you able to submit the gsj device tree (or get someone
who has worked on that to do so?) for inclusion too? Similarly for the
runbmc device tree.

We also lack a nuvoton configuration. We can submit one, or rely on
the multi_v7 for upstream testing. What would you prefer?

> The following device node add:
>         - NPCM7xx Pin controller and GPIO
>         - NPCM7xx PWM and FAN.
>         - NPCM7xx EHCI USB.
>         - NPCM7xx KCS.
>         - NPCM Reset.
>         - NPCM Peripheral SPI.
>         - NPCM FIU SPI.
>         - NPCM HWRNG.
>         - NPCM I2C.
>         - STMicro STMMAC.

Does the STMMAC only appear in the 750 (and not the 730)? I was
wondering why it appeared in the 750 dtsi and not the common dtsi.

Cheers,

Joel

>
> The following device node modified:
>         - NPCM7xx timer.
>         - NPCM7xx clock constants parameters.
>
> NPCM7xx device tree tested on NPCM750 evaluation board.
>
> Changes since version 4:
>  - Tested patches in Linux kernel 5.9.
>
> Changes since version 3:
>  - Tested patches in Linux kernel 5.6.
>
> Changes since version 2:
>  - Remove unnecessary output-enable flags.
>
> Changes since version 1:
>  - Add NPCM reset device node.
>  - Add reset parameters to NPCM driver device nodes.
>
> Tomer Maimon (3):
>   arm: dts: modify NPCM7xx device tree clock parameter
>   arm: dts: modify NPCM7xx device tree timer register size
>   arm: dts: add new device nodes to NPCM750 device tree
>
>  arch/arm/boot/dts/nuvoton-common-npcm7xx.dtsi | 974 +++++++++++++++++-
>  arch/arm/boot/dts/nuvoton-npcm750-evb.dts     | 404 +++++++-
>  .../boot/dts/nuvoton-npcm750-pincfg-evb.dtsi  | 157 +++
>  arch/arm/boot/dts/nuvoton-npcm750.dtsi        |  24 +-
>  4 files changed, 1522 insertions(+), 37 deletions(-)
>  create mode 100644 arch/arm/boot/dts/nuvoton-npcm750-pincfg-evb.dtsi
>
> --
> 2.22.0
>