Re: [PATCH V4] serial: qcom_geni_serial: To correct QUP Version detection logic

[Greg Kroah-Hartman]

On Mon, Sep 14, 2020 at 12:49:17PM +0530, Paras Sharma wrote:
> The current implementation reduces the sampling rate by half
> if qup HW version is  greater is than 2.5 by checking if the

2 space characters?

And what is "qup"?

What is "HW"?

> geni SE major version is greater than 2 and geni SE minor version

what is "geni"?

What is "SE"?

> is greater than 5.This implementation fails when the version is
> greater than or equal to 3.
> 
> Hence, a new macro QUP_SE_VERSION_2_5 is defined having value
> for major number 2 and minor number 5 as 0x20050000.Hence,if 

That's not a "macro", it is a simple #define.

And can you use a ' ' after a '.' please?  That's all over this
changelog, including trailing whitespace for some reason :(

> ver is greater than this value,sampling rate is halved. 
> This logic would work for any future qup version.

"will work"?

> 
> Fixes: ce734600545f ("tty: serial: qcom_geni_serial: Update the oversampling rate")
> Signed-off-by: Paras Sharma <parashar@xxxxxxxxxxxxxx>
> ---
> Changes in V4:
> Created a new macro QUP_SE_VERSION_2_5 for Qup se version 2.5
> 

What changed from previous versions than v4?

thanks,

greg k-h