Re: [PATCH] ath10k: sdio: remove reduntant check in for loop

From: Alex Dewar
Date: Wed Sep 16 2020 - 15:39:44 EST


[snip]
'i' is only referenced once inside the loop to check boundary,

the loop is actually iterating over cur_section, so i would make it
clear in the loop statement, e.g.:
Remove the break condition and the cur_section assignment at the end of
the loop and use the loop statement to do it for you

for (; cur_section; cur_section = next_section)


section_size = cur_section->end - cur_section->start;
if (section_size <= 0) {
@@ -2318,7 +2318,7 @@ static int
ath10k_sdio_dump_memory_section(struct ath10k *ar,
break;
}
- if ((i + 1) == mem_region->section_table.size) {
And for i you can just increment it inline:
if (++i == ...)

Good suggestions! I've sent a v2 with these changes.


+ if (i == mem_region->section_table.size) {
/* last section */
next_section = NULL;
skip_size = 0;