Re: [PATCH v2] software_node: Add support for fwnode_graph*() family of functions

From: Andy Shevchenko
Date: Wed Sep 16 2020 - 17:05:49 EST

On Wed, Sep 16, 2020 at 04:06:25PM +0100, Kieran Bingham wrote:
> On 16/09/2020 14:22, Dan Scally wrote:
> > On 16/09/2020 10:17, Sakari Ailus wrote:
> >> On Wed, Sep 16, 2020 at 12:28:27AM +0100, Daniel Scally wrote:

Thank you, Kieran, for detailed explanation, one small correction below though.


> >> This looks like a bugfix that probably should or could be backported. Could
> >> you make it a separate patch, with a Fixes: tag?
> > Yes, sure. That does change how some of the other code would need to
> > work though if this patch were applied but not the separated one. Sorry;
> > not sure what's the best way to proceed in that case. Should I just note
> > that this patch depends on the prior application of the separated one?
> I think the assumption is that this individual change to
> software_node_property_present() should be in a patch on it's own
> preceeding 'this' one.
> Running git-blame on drivers/base/swnode.c identifies this line as
> previously being added by: 59abd83672f70, so you would add the tag:

> Fixes: 59abd83672f7 ("drivers: base: Introducing software nodes to the
> firmware node framework")

Just to point out that this must be on one line.

> to the 'fixing' patch, and that can be backported accordingly.
> When patches are sent in a series, the dependency becomes implicit.
> You can do this by specifying a range when you do `git format-patch`
> If you want to save off the last '2' patches, you can use a range
> shorthand of '-2':
> for example:
> git format-patch -2 -v3 --cover-letter -o patches/swnode
> As it's a 'series' we add a cover letter to group them, and that gives a
> location to add some free-form text as you wish too.

With Best Regards,
Andy Shevchenko