Re: [PATCH 1/5] dt-bindings: phy: qcom,qmp: Document SM8250 PCIe PHY bindings

[Bjorn Andersson]

On Wed 16 Sep 08:19 CDT 2020, Manivannan Sadhasivam wrote:

> Document the DT bindings of below PCIe PHY versions used on SM8250:
> 
> QMP GEN3x1 PHY - 1 lane
> QMP GEN3x2 PHY - 2 lanes
> QMP Modem PHY - 2 lanes

How about something like "Add the three PCIe PHYs found in SM8250 to the
QMP binding"?

> 
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>
> ---
>  Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> index 185cdea9cf81..69b67f79075c 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> @@ -31,6 +31,9 @@ properties:
>        - qcom,sdm845-qmp-usb3-uni-phy
>        - qcom,sm8150-qmp-ufs-phy
>        - qcom,sm8250-qmp-ufs-phy
> +      - qcom,qcom,sm8250-qmp-gen3x1-pcie-phy
> +      - qcom,qcom,sm8250-qmp-gen3x2-pcie-phy
> +      - qcom,qcom,sm8250-qmp-modem-pcie-phy

One "qcom," should be enough.

>  
>    reg:
>      items:
> @@ -259,6 +262,8 @@ allOf:
>              enum:
>                - qcom,sdm845-qhp-pcie-phy
>                - qcom,sdm845-qmp-pcie-phy
> +              - qcom,sm8250-qhp-pcie-phy
> +              - qcom,sm8250-qmp-pcie-phy

Adjust these.

Regards,
Bjorn

>      then:
>        properties:
>          clocks:
> -- 
> 2.17.1
>