Re: [PATCH] gpio: aspeed: fix ast2600 bank properties

From: Andrew Jeffery
Date: Wed Sep 16 2020 - 19:13:11 EST




On Thu, 17 Sep 2020, at 06:12, rentao.bupt@xxxxxxxxx wrote:
> From: Tao Ren <rentao.bupt@xxxxxxxxx>
>
> GPIO_U is mapped to the least significant byte of input/output mask, and
> the byte in "output" mask should be 0 because GPIO_U is input only. All
> the other bits need to be 1 because GPIO_V/W/X support both input and
> output modes.
>
> Similarly, GPIO_Y/Z are mapped to the 2 least significant bytes, and the
> according bits need to be 1 because GPIO_Y/Z support both input and
> output modes.
>
> Fixes: ab4a85534c3e ("gpio: aspeed: Add in ast2600 details to Aspeed driver")
> Signed-off-by: Tao Ren <rentao.bupt@xxxxxxxxx>

Thanks Tao,

Reviewed-by: Andrew Jeffery <andrew@xxxxxxxx>