Re: [PATCH] erofs: remove unneeded parameter

From: Chao Yu
Date: Wed Sep 16 2020 - 21:21:00 EST

Hi Xiang,

On 2020/9/16 22:36, Gao Xiang wrote:
On Wed, Sep 16, 2020 at 10:33:04PM +0800, Gao Xiang wrote:
Hi Chao,

On Wed, Sep 16, 2020 at 10:06:04PM +0800, Chao Yu wrote:
From: Chao Yu <yuchao0@xxxxxxxxxx>

In below call path, no page will be cached into @pagepool list
or grabbed from @pagepool list:
- z_erofs_readpage
- z_erofs_do_read_page
- preload_compressed_pages
- erofs_allocpage

Let's get rid of this unneeded parameter.

That would be unneeded after .readahead() is introduced recently
(so add_to_page_cache_lru() is also moved to mm code), so I agree
with you on it.


... also it'd be better to add such historical reason to the commit
message... since it was of some use before...

No problem, let me revise it in v2. :)


Gao Xiang