Re: [RESEND v2 2/4] venus: core: vote for video-mem path

From: Stephen Boyd
Date: Thu Sep 17 2020 - 03:20:41 EST


Quoting Mansur Alisha Shaik (2020-09-16 18:26:01)
> diff --git a/drivers/media/platform/qcom/venus/core.c b/drivers/media/platform/qcom/venus/core.c
> index 52a3886..064b6c8 100644
> --- a/drivers/media/platform/qcom/venus/core.c
> +++ b/drivers/media/platform/qcom/venus/core.c
> @@ -363,8 +363,16 @@ static __maybe_unused int venus_runtime_suspend(struct device *dev)
>
> ret = icc_set_bw(core->cpucfg_path, 0, 0);
> if (ret)
> - return ret;
> + goto err_poweron_core;
> +
> + ret = icc_set_bw(core->video_path, 0, 0);
> + if (ret)
> + goto err_poweron_core;
> +
> + return ret;
>
> +err_poweron_core:
> + pm_ops->core_power(dev, POWER_ON);

Don't we need to put back the bandwidth from before suspend was entered
if the video_path fails?

> return ret;
> }
>