Re: [PATCH v2 05/10] mm, kfence: insert KFENCE hooks for SLUB

From: Alexander Potapenko
Date: Thu Sep 17 2020 - 05:51:40 EST


On Thu, Sep 17, 2020 at 11:40 AM Christopher Lameter <cl@xxxxxxxxx> wrote:
>
> On Tue, 15 Sep 2020, Marco Elver wrote:
>
> > void *kmem_cache_alloc(struct kmem_cache *s, gfp_t gfpflags)
> > {
> > - void *ret = slab_alloc(s, gfpflags, _RET_IP_);
> > + void *ret = slab_alloc(s, gfpflags, _RET_IP_, s->object_size);
>
> The additional size parameter is a part of a struct kmem_cache that is
> already passed to the function. Why does the parameter list need to be
> expanded?

See my response to the similar question about the SLAB allocator:
https://lore.kernel.org/linux-arm-kernel/CAG_fn=XMc8NPZPFtUE=rdoR=XJH4F+TxZs-w5n4VuaWKTjcasw@xxxxxxxxxxxxxx/



--
Alexander Potapenko
Software Engineer

Google Germany GmbH
Erika-Mann-Straße, 33
80636 München

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg