Re: [RFC PATCH] locking/percpu-rwsem: use this_cpu_{inc|dec}() for read_count

From: Boaz Harrosh
Date: Thu Sep 17 2020 - 06:53:33 EST


On 16/09/2020 15:32, Hou Tao wrote:
<>
However the performance degradation is huge under aarch64 (4 sockets, 24 core per sockets): nearly 60% lost.

v4.19.111
no writer, reader cn | 24 | 48 | 72 | 96
the rate of down_read/up_read per second | 166129572 | 166064100 | 165963448 | 165203565
the rate of down_read/up_read per second (patched) | 63863506 | 63842132 | 63757267 | 63514920


I believe perhaps Peter Z's suggestion of an additional
percpu_down_read_irqsafe() API and let only those in IRQ users pay the penalty.

Peter Z wrote:
My leading alternative was adding: percpu_down_read_irqsafe() /
percpu_up_read_irqsafe(), which use local_irq_save() instead of
preempt_disable().

Thanks
Boaz