Re: [PATCH v2 02/10] dt-bindings: mfd: Add binding for Netronix's embedded controller

From: Jonathan Neuschäfer
Date: Thu Sep 17 2020 - 07:18:35 EST

On Mon, Sep 14, 2020 at 06:50:34PM -0600, Rob Herring wrote:
> On Sat, Sep 05, 2020 at 03:32:22PM +0200, Jonathan Neuschäfer wrote:
> > This EC is found in e-book readers of multiple brands (e.g. Kobo,
> > Tolino), and is typically implemented as a TI MSP430 microcontroller.

> > +required:
> > + - compatible
> > + - reg
> additionalProperties: false

Ok, I'll add that.

> > + interrupt-controller;
> > + #interrupt-cells = <1>;
> These need to be documented too.

Interrupt support is something I haven't really worked out yet for this
(set of) binding(s). My idea here was to have the embedded-controller
node act as an interrupt controller, and the subnodes use specific
interrupts that are relevant for their functionality.

I think I'll rather omit the interrupt-controller and #interrupt-cells
properties now, and add them later if they become necessary. If the pwm
and rtc nodes are merged into the main node, I don't think they will
become necessary.

Jonathan Neuschäfer

Attachment: signature.asc
Description: PGP signature