[PATCH 1/1] KVM: x86: fix MSR_IA32_TSC read for nested migration

From: Maxim Levitsky
Date: Thu Sep 17 2020 - 07:25:32 EST

MSR reads/writes should always access the L1 state, since the (nested)
hypervisor should intercept all the msrs it wants to adjust, and these
that it doesn't should be read by the guest as if the host had read it.

However IA32_TSC is an exception.Even when not intercepted, guest still
reads the value + TSC offset.
The write however does not take any TSC offset in the account.

This is documented in Intel's PRM and seems also to happen on AMD as well.

This creates a problem when userspace wants to read the IA32_TSC value and then
write it. (e.g for migration)

In this case it reads L2 value but write is interpreted as an L1 value.
To fix this make the userspace initiated reads of IA32_TSC return L1 value
as well.

Huge thanks to Dave Gilbert for helping me understand this very confusing
semantic of MSR writes.

Signed-off-by: Maxim Levitsky <mlevitsk@xxxxxxxxxx>
arch/x86/kvm/x86.c | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)

diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index 17f4995e80a7e..d10d5c6add359 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -2025,6 +2025,11 @@ u64 kvm_read_l1_tsc(struct kvm_vcpu *vcpu, u64 host_tsc)

+static u64 kvm_read_l2_tsc(struct kvm_vcpu *vcpu, u64 host_tsc)
+ return vcpu->arch.tsc_offset + kvm_scale_tsc(vcpu, host_tsc);
static void kvm_vcpu_write_tsc_offset(struct kvm_vcpu *vcpu, u64 offset)
vcpu->arch.l1_tsc_offset = offset;
@@ -3220,7 +3225,19 @@ int kvm_get_msr_common(struct kvm_vcpu *vcpu, struct msr_data *msr_info)
msr_info->data = vcpu->arch.msr_ia32_power_ctl;
case MSR_IA32_TSC:
- msr_info->data = kvm_scale_tsc(vcpu, rdtsc()) + vcpu->arch.tsc_offset;
+ /*
+ * Intel PRM states that MSR_IA32_TSC read adds the TSC offset
+ * even when not intercepted. AMD manual doesn't define this
+ * but appears to behave the same
+ *
+ * However when userspace wants to read this MSR, return its
+ * real L1 value so that its restore will be correct
+ *
+ */
+ if (msr_info->host_initiated)
+ msr_info->data = kvm_read_l1_tsc(vcpu, rdtsc());
+ else
+ msr_info->data = kvm_read_l2_tsc(vcpu, rdtsc());
case MSR_MTRRcap:
case 0x200 ... 0x2ff: