Re: [PATCH 2/2] vfio/pci: Remove bardirty from vfio_pci_device
From: Cornelia Huck
Date: Thu Sep 17 2020 - 07:40:11 EST
On Thu, 17 Sep 2020 11:31:28 +0800
Zenghui Yu <yuzenghui@xxxxxxxxxx> wrote:
> It isn't clear what purpose the @bardirty serves. It might be used to avoid
> the unnecessary vfio_bar_fixup() invoking on a user-space BAR read, which
> is not required when bardirty is unset.
> The variable was introduced in commit 89e1f7d4c66d ("vfio: Add PCI device
> driver") but never actually used, so it shouldn't be that important. Remove
> Signed-off-by: Zenghui Yu <yuzenghui@xxxxxxxxxx>
> drivers/vfio/pci/vfio_pci_config.c | 7 -------
> drivers/vfio/pci/vfio_pci_private.h | 1 -
> 2 files changed, 8 deletions(-)
Yes, it seems to have been write-only all the time.
Reviewed-by: Cornelia Huck <cohuck@xxxxxxxxxx>