Re: [RFC PATCH] Add bridge driver to connect sensors to CIO2 device via software nodes on ACPI platforms

From: Kieran Bingham
Date: Thu Sep 17 2020 - 09:47:54 EST

Hi Dan, Greg,

On 17/09/2020 10:47, Dan Scally wrote:
> Hi Greg - thanks for the comments, appreciate it (sorry there's so many,
> I'm new to both C and kernel work)
> On 17/09/2020 08:53, Greg KH wrote:
>> On Wed, Sep 16, 2020 at 10:36:18PM +0100, Daniel Scally wrote:
>>> drivers/media/pci/intel/ipu3/ipu3-cio2.c | 67 +++-
>> staging drivers should be self-contained, and not modify stuff outside
>> of drivers/staging/
>>> drivers/staging/media/ipu3/Kconfig | 15 +
>>> drivers/staging/media/ipu3/Makefile | 1 +
>>> drivers/staging/media/ipu3/cio2-bridge.c | 448 +++++++++++++++++++++++
>> Why does this have to be in drivers/staging/ at all? Why not spend the
>> time to fix it up properly and get it merged correctly? It's a very
>> small driver, and should be smaller, so it should not be a lot of work
>> to do. And it would be faster to do that than to take it through
>> staging...
> I was just under the impression that that was the process to be honest,
> if that's not right I'll just move it directly to drivers/media/ipu3

The IPU3 driver is still in staging (unless I've missed something), so I
think this cio2-bridge should stay with it.

Hopefully with more users of the IPU3 brought in by this cio2-bridge,
that will help gather momentum to get the IPU3 developments required
completed and moved into drivers/media.