Re: [PATCH v18 00/32] per memcg lru_lock: reviews

From: Daniel Jordan
Date: Thu Sep 17 2020 - 12:47:22 EST


On Thu, Sep 17, 2020 at 08:39:34AM -0700, Alexander Duyck wrote:
> On Thu, Sep 17, 2020 at 7:26 AM Daniel Jordan
> <daniel.m.jordan@xxxxxxxxxx> wrote:
> >
> > On Thu, Sep 17, 2020 at 10:37:45AM +0800, Alex Shi wrote:
> > > 在 2020/9/16 上午12:58, Daniel Jordan 写道:
> > > > On Tue, Sep 15, 2020 at 01:21:56AM -0700, Hugh Dickins wrote:
> > > >> On Sun, 13 Sep 2020, Alex Shi wrote:
> > > >>> Uh, I updated the testing with some new results here:
> > > >>> https://lkml.org/lkml/2020/8/26/212
> > > >> Right, I missed that, that's better, thanks. Any other test results?
> > > > Alex, you were doing some will-it-scale runs earlier. Are you planning to do
> > > > more of those? Otherwise I can add them in.
> > >
> > > Hi Daniel,
> > >
> > > Does compaction perf scalable, like thpscale, I except they could get some benefit.
> >
> > Yep, I plan to stress compaction. Reclaim as well.
> >
> > I should have said which Alex I meant. I was asking Alex Duyck since he'd done
> > some will-it-scale runs.
>
> I probably won't be able to do any will-it-scale runs any time soon.
> If I recall I ran them for this latest v18 patch set and didn't see
> any regressions like I did with the previous set. However the system I
> was using is tied up for other purposes and it may be awhile before I
> can free it up to look into this again.

Ok, sure. I hadn't seen the regressions were taken case of, that's good to
hear. Might still add them to my testing for v19 and beyond, we'll see.