Re: [PATCH V7 1/4] perf/core: Add PERF_SAMPLE_DATA_PAGE_SIZE

[Dave Hansen]

On 9/17/20 2:58 PM, Liang, Kan wrote:
> The user space perf tool looks like a better place for this kind of
> warning. The perf tool knows the total number of the samples. It also
> knows the number of the page size 0 samples. We can set a threshold,
> e.g., 90%. If 90% of the samples have the page size 0, perf tool will
> throw out a warning message.

Sounds good to me.

> The problem is that the warning from the perf tool usually includes some
> hints regarding the cause of the warning or possible solution to
> workaround/fix the warning. What message should we deliver to the users?
> "Warning: Too many error page size. Address space isolation feature may
> be enabled, please check"?

That's not particularly actionable for an end user.  Do any of the perf
errors just tell them to submit a bug report?  "Excessive number of page
size lookup errors, please report to..."