Re: [PATCH printk 2/3] printk: move dictionary keys to dev_printk_info

[Rasmus Villemoes]

On 17/09/2020 15.16, John Ogness wrote:

>  	if (dev->class)
>  		subsys = dev->class->name;
>  	else if (dev->bus)
>  		subsys = dev->bus->name;
>  	else
> -		return 0;
> +		return;
>  
> -	pos += snprintf(hdr + pos, hdrlen - pos, "SUBSYSTEM=%s", subsys);
> -	if (pos >= hdrlen)
> -		goto overflow;
> +	snprintf(dev_info->subsystem, sizeof(dev_info->subsystem), subsys);

It's unlikely that subsys would contain a %, but this will be yet
another place to spend brain cycles ignoring if doing static analysis.
So can we not do this. Either of strXcpy() for X=s,l will do the same
thing, and likely faster.

Rasmus