Re: [PATCH v2 01/13] dt-bindings: gpio: add common schema for GPIO controllers
From: Krzysztof Kozlowski
Date: Fri Sep 18 2020 - 03:53:16 EST
On Thu, 17 Sep 2020 at 22:10, Laurent Pinchart
> Hi Krzysztof,
> Thank you for the patch.
> On Thu, Sep 17, 2020 at 06:52:49PM +0200, Krzysztof Kozlowski wrote:
> > Convert parts of gpio.txt bindings into common dtschema file for GPIO
> > controllers.
> How about deleting the part that has been converted from gpio.txt ?
I did not move everything from the gpio.txt and it is really nicely
explained there. I think to leave it as it works as a overview/guide
better than YAML.
> > The schema enforces proper naming of GPIO controller nodes and GPIO
> > hogs.
> > The schema should be included by specific GPIO controllers bindings.
> Instead of including it manually, could we use a conditional select: to
> apply the schema automatically when a gpio-controller property is
> present ?
You mean the same way as generic schema for GPIO controllers work?
This could be done but the point is to enforce the GPIO controller
bindings in GPIO controllers, so also in cases when someone forgets to
add "gpio-controller" property. Although, if given GPIO controller
schema requires "gpio-controller" then indeed select would work...