Re: [PATCH 3/3] crypto: hisilicon/hpre - fix a bug in dh algorithm

From: yumeng
Date: Fri Sep 18 2020 - 04:45:12 EST

Yes, 'u64' is redundant, I will resend one!
Thank you!


On 2020/9/18 15:11, Herbert Xu wrote:
On Thu, Sep 10, 2020 at 07:25:22PM +0800, Meng Yu wrote:

diff --git a/drivers/crypto/hisilicon/hpre/hpre_crypto.c b/drivers/crypto/hisilicon/hpre/hpre_crypto.c
index 0cbe99a1..2d91593 100644
--- a/drivers/crypto/hisilicon/hpre/hpre_crypto.c
+++ b/drivers/crypto/hisilicon/hpre/hpre_crypto.c
@@ -528,6 +528,8 @@ static int hpre_dh_compute_value(struct kpp_request *req)
ret = hpre_hw_data_init(hpre_req, req->src, req->src_len, 1, 1);
if (unlikely(ret))
goto clear_all;
+ } else {
+ msg->in = cpu_to_le64((u64)ctx->dh.dma_g);

Why do you need the u64 cast?

Cheers,