Re: [PATCH 3/3] hwmon: (lm75) Add regulator support

From: Mark Brown
Date: Fri Sep 18 2020 - 06:04:23 EST


On Thu, Sep 17, 2020 at 07:04:51PM -0700, Guenter Roeck wrote:
> On 9/17/20 4:00 AM, Mark Brown wrote:
> > On Thu, Sep 17, 2020 at 12:18:19PM +0200, Alban Bedel wrote:

> >> + data->vs = devm_regulator_get_optional(dev, "vs");
> >> + if (IS_ERR(data->vs)) {

> > Unless the device can work without power you should not be using
> > regulator_get_optional().

> The driver works today without regulator, and needs to continue
> doing so.

And it will continue to do so if it uses the normal regulator API, it
will as ever ensure that if no regulator is provided by the firmware a
dummy is provided.

Attachment: signature.asc
Description: PGP signature