Re: [PATCH 04/26] perf tools: Add filename__decompress function

[Jiri Olsa]

On Thu, Sep 17, 2020 at 03:54:55PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Sep 14, 2020 at 10:43:26PM +0200, Jiri Olsa escreveu:
> > On Mon, Sep 14, 2020 at 12:35:54PM -0300, Arnaldo Carvalho de Melo wrote:
> > > Em Sun, Sep 13, 2020 at 11:02:51PM +0200, Jiri Olsa escreveu:
> > > > Factor filename__decompress from decompress_kmodule function.
> > > > It can decompress files with compressions supported in perf -
> > > > xz and gz, the support needs to be compiled in.
> > > > 
> > > > It will to be used in following changes to get build id out of
> > > > compressed elf objects.
> > > 
> > > This is prep work, can be applied now, done.
> > 
> > thanks,
> > jirka
> 
> So, I take that back, one of these decompress patches is causing this:
> 
> [root@five ~]# perf list syscalls:sys_enter_open |& tail
> lzma: fopen failed on /usr/lib/modules/5.6.19-200.fc31.x86_64/kernel/drivers/acpi/video.ko.xz: 'No such file or directory'
> lzma: fopen failed on /usr/lib/modules/5.5.8-200.fc31.x86_64/kernel/net/ipv4/netfilter/nf_reject_ipv4.ko.xz: 'No such file or directory'
> lzma: fopen failed on /usr/lib/modules/5.5.9-200.fc31.x86_64/kernel/net/ipv6/netfilter/ip6_tables.ko.xz: 'No such file or directory'
> lzma: fopen failed on /usr/lib/modules/5.5.5-200.fc31.x86_64/kernel/drivers/crypto/ccp/ccp.ko.xz: 'No such file or directory'
> lzma: fopen failed on /usr/lib/modules/5.4.20-200.fc31.x86_64/kernel/sound/pci/hda/snd-hda-codec.ko.xz: 'No such file or directory'
> lzma: fopen failed on /usr/lib/modules/5.5.15-200.fc31.x86_64/kernel/drivers/target/target_core_mod.ko.xz: 'No such file or directory'
> lzma: fopen failed on /usr/lib/modules/5.3.7-301.fc31.x86_64/kernel/drivers/iommu/amd_iommu_v2.ko.xz: 'No such file or directory'
> lzma: fopen failed on /usr/lib/modules/5.3.7-301.fc31.x86_64/kernel/drivers/media/v4l2-core/videodev.ko.xz: 'No such file or directory'
> lzma: fopen failed on /usr/lib/modules/5.6.19-200.fc31.x86_64/kernel/net/ipv4/netfilter/iptable_filter.ko.xz: 'No such file or directory'
>   syscalls:sys_enter_open                            [Tracepoint event]
> [root@five ~]# perf test 78
> 78: Check open filename arg using perf trace + vfs_getname          : FAILED!
> [root@five ~]#
> [root@five ~]# uname -a
> Linux five 5.9.0-rc3 #1 SMP Mon Aug 31 08:38:27 -03 2020 x86_64 x86_64 x86_64 GNU/Linux
> [root@five ~]#
> 
> So I removed them from my local branch, I'll rerun the build tests and
> then push perf/core when all tests pass.
> 
> The test uses 'perf probe' and I noticed it when processing Masami's
> debuginfod patches to make 'perf probe' use it, I thought it was his
> patches, looking only at the 'perf test 78' output, but ended up being
> the decompress ones.

ok, will check on that

thanks,
jirka