Re: [PATCH v5] iio: adc: ad7768-1: Add channel label example

From: kernel test robot
Date: Fri Sep 18 2020 - 08:58:40 EST


Hi Cristian,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on iio/togreg]
[also build test ERROR on linux/master linus/master v5.9-rc5 next-20200918]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/0day-ci/linux/commits/Cristian-Pop/iio-adc-ad7768-1-Add-channel-label-example/20200918-190340
base: https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
# save the attached .config to linux build tree
make W=1 ARCH=x86_64

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

>> drivers/iio/adc/ad7768-1.c:432:3: error: 'const struct iio_info' has no member named 'read_label'; did you mean 'read_raw'?
432 | .read_label = ad7768_read_label,
| ^~~~~~~~~~
| read_raw
>> drivers/iio/adc/ad7768-1.c:432:16: error: initialization of 'int (*)(struct iio_dev *, const struct iio_chan_spec *, long int)' from incompatible pointer type 'int (*)(struct iio_dev *, const struct iio_chan_spec *, char *)' [-Werror=incompatible-pointer-types]
432 | .read_label = ad7768_read_label,
| ^~~~~~~~~~~~~~~~~
drivers/iio/adc/ad7768-1.c:432:16: note: (near initialization for 'ad7768_info.write_raw_get_fmt')
cc1: some warnings being treated as errors

# https://github.com/0day-ci/linux/commit/6144f5a8d7fa8961b6d39e36092c14301ad823c1
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Cristian-Pop/iio-adc-ad7768-1-Add-channel-label-example/20200918-190340
git checkout 6144f5a8d7fa8961b6d39e36092c14301ad823c1
vim +432 drivers/iio/adc/ad7768-1.c

427
428 static const struct iio_info ad7768_info = {
429 .attrs = &ad7768_group,
430 .read_raw = &ad7768_read_raw,
431 .write_raw = &ad7768_write_raw,
> 432 .read_label = ad7768_read_label,
433 .debugfs_reg_access = &ad7768_reg_access,
434 };
435

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip