Re: [PATCH v2 09/13] dt-bindings: pinctrl: include common schema in GPIO controllers

From: Laurent Pinchart
Date: Fri Sep 18 2020 - 10:21:02 EST


Hi Krzysztof,

On Fri, Sep 18, 2020 at 10:19:25AM +0200, Krzysztof Kozlowski wrote:
> On Thu, 17 Sep 2020 at 22:12, Laurent Pinchart wrote:
> > On Thu, Sep 17, 2020 at 06:52:57PM +0200, Krzysztof Kozlowski wrote:
> > > Include the common GPIO schema in GPIO controllers to be sure all common
> > > properties are properly validated.
> >
> > Shouldn't we delete the properties that are now redundant from these
> > schemas ?
>
> Good point. However not with "additionalPropeties: false". Schema
> requires all properties to be mentioned. I would need to use
> "unevaluatedProperties: false" in each file.
>
> What is preferred?

I've seen Rob advocating for unevaluatedProperties multiple times, but
I'll let him comment on this, I don't want to speak for him.

--
Regards,

Laurent Pinchart