Re: [PATCH] objtool: ignore unreachable trap after call to noreturn functions
From: Josh Poimboeuf
Date: Fri Sep 18 2020 - 11:51:54 EST
On Fri, Sep 18, 2020 at 08:35:40AM +0300, Ilie Halip wrote:
> > The patch looks good to me. Which versions of Clang do the trap after
> > noreturn call? It would be good to have that in the commit message.
>
> I omitted this because it happens with all versions of clang that are
> supported for building the kernel. clang-9 is the oldest version that
> could build the mainline x86_64 kernel right now, and it has the same
> behavior.
Ok. It should at least mention that this is a Clang-specific thing,
since GCC's version of UBSAN_TRAP doesn't do it.
> Should I send a v2 with this info?
Yes, please.
--
Josh