Re: [PATCH net-next] liquidio: Fix -Wmissing-prototypes warnings for liquidio
From: Saeed Mahameed
Date: Fri Sep 18 2020 - 13:43:52 EST
On Fri, 2020-09-18 at 21:02 +0800, Wang Hai wrote:
> If the header file containing a function's prototype isn't included
> by
> the sourcefile containing the associated function, the build system
> complains of missing prototypes.
>
> Fixes the following W=1 kernel build warning(s):
>
> drivers/net/ethernet/cavium/liquidio/cn68xx_device.c:124:5: warning:
> no previous prototype for ‘lio_setup_cn68xx_octeon_device’ [-
> Wmissing-prototypes]
> drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:159:1: warning:
> no previous prototype for ‘octeon_pci_read_core_mem’ [-Wmissing-
> prototypes]
> drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:168:1: warning:
> no previous prototype for ‘octeon_pci_write_core_mem’ [-Wmissing-
> prototypes]
> drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:176:5: warning:
> no previous prototype for ‘octeon_read_device_mem64’ [-Wmissing-
> prototypes]
> drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:185:5: warning:
> no previous prototype for ‘octeon_read_device_mem32’ [-Wmissing-
> prototypes]
> drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:194:6: warning:
> no previous prototype for ‘octeon_write_device_mem32’ [-Wmissing-
> prototypes]
>
> Signed-off-by: Wang Hai <wanghai38@xxxxxxxxxx>
>
Reviewed-by: Saeed Mahameed <saeedm@xxxxxxxxxx>