Re: [PATCH v2] ptp: mark symbols static where possible

From: David Miller
Date: Fri Sep 18 2020 - 17:15:59 EST

From: Herrington <hankinsea@xxxxxxxxx>
Date: Fri, 18 Sep 2020 14:10:13 +0800

> +void pch_ch_control_write(struct pci_dev *pdev, u32 val);
> void pch_ch_control_write(struct pci_dev *pdev, u32 val)

Prototypes belong in a header file not in the C file where they
are defined.

If these functions are accessed in other foo.c files, they are
getting the prototype from some header file.

Otherwise they aren't, and the functions should be marked