Re: [PATCH net-next v2] net: phy: bcm7xxx: request and manage GPHY clock

From: David Miller
Date: Fri Sep 18 2020 - 20:22:23 EST


From: Florian Fainelli <f.fainelli@xxxxxxxxx>
Date: Wed, 16 Sep 2020 19:04:13 -0700

> The internal Gigabit PHY on Broadcom STB chips has a digital clock which
> drives its MDIO interface among other things, the driver now requests
> and manage that clock during .probe() and .remove() accordingly.
>
> Because the PHY driver can be probed with the clocks turned off we need
> to apply the dummy BMSR workaround during the driver probe function to
> ensure subsequent MDIO read or write towards the PHY will succeed.
>
> Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
> ---
> Changes in v2:
>
> - localize the changes exclusively within the PHY driver and do not
> involve the MDIO driver at all. Using the ethernet-phyidAAAA.BBBB
> compatible string we can get straight to the desired driver without
> requiring clocks to be assumed on.

Applied and queued up for -stable, thanks.