Re: [PATCH] net: ipv6: fix kconfig dependency warning for IPV6_SEG6_HMAC
From: David Miller
Date: Fri Sep 18 2020 - 20:45:50 EST
From: Necip Fazil Yildiran <fazilyildiran@xxxxxxxxx>
Date: Thu, 17 Sep 2020 19:46:43 +0300
> When IPV6_SEG6_HMAC is enabled and CRYPTO is disabled, it results in the
> following Kbuild warning:
>
> WARNING: unmet direct dependencies detected for CRYPTO_HMAC
> Depends on [n]: CRYPTO [=n]
> Selected by [y]:
> - IPV6_SEG6_HMAC [=y] && NET [=y] && INET [=y] && IPV6 [=y]
>
> WARNING: unmet direct dependencies detected for CRYPTO_SHA1
> Depends on [n]: CRYPTO [=n]
> Selected by [y]:
> - IPV6_SEG6_HMAC [=y] && NET [=y] && INET [=y] && IPV6 [=y]
>
> WARNING: unmet direct dependencies detected for CRYPTO_SHA256
> Depends on [n]: CRYPTO [=n]
> Selected by [y]:
> - IPV6_SEG6_HMAC [=y] && NET [=y] && INET [=y] && IPV6 [=y]
>
> The reason is that IPV6_SEG6_HMAC selects CRYPTO_HMAC, CRYPTO_SHA1, and
> CRYPTO_SHA256 without depending on or selecting CRYPTO while those configs
> are subordinate to CRYPTO.
>
> Honor the kconfig menu hierarchy to remove kconfig dependency warnings.
>
> Fixes: bf355b8d2c30 ("ipv6: sr: add core files for SR HMAC support")
> Signed-off-by: Necip Fazil Yildiran <fazilyildiran@xxxxxxxxx>
Applied and queued up for -stable, thank you.