Re: [PATCH] scsi: arcmsr: Remove the superfluous break

[Jing Xiangfeng]

On 2020/9/18 22:56, Gustavo A. R. Silva wrote:
> On Fri, Sep 18, 2020 at 05:32:30PM +0800, Jing Xiangfeng wrote:
> > Remove the superfluous break, as there is a 'return' before it.
>
> Apparently, the change is correct. Please, just add a proper Fixes tag by
> yourself this time.

Thanks for comments! I'll resend with the following Fixes tag:

Fixes: 6b3937227479 ("arcmsr: fix command timeout under heavy load")
> Thanks
> --
> Gustavo
>
> > Signed-off-by: Jing Xiangfeng <jingxiangfeng@xxxxxxxxxx>
> > ---
> >   drivers/scsi/arcmsr/arcmsr_hba.c | 2 --
> >   1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c
> > index ec895d0319f0..74add6d247d5 100644
> > --- a/drivers/scsi/arcmsr/arcmsr_hba.c
> > +++ b/drivers/scsi/arcmsr/arcmsr_hba.c
> > @@ -2699,10 +2699,8 @@ static irqreturn_t arcmsr_interrupt(struct AdapterControlBlock *acb)
> >   	switch (acb->adapter_type) {
> >   	case ACB_ADAPTER_TYPE_A:
> >   		return arcmsr_hbaA_handle_isr(acb);
> > -		break;
> >   	case ACB_ADAPTER_TYPE_B:
> >   		return arcmsr_hbaB_handle_isr(acb);
> > -		break;
> >   	case ACB_ADAPTER_TYPE_C:
> >   		return arcmsr_hbaC_handle_isr(acb);
> >   	case ACB_ADAPTER_TYPE_D:
> > --
> > 2.17.1
> .