Re: [PATCH v3 00/14] Adding GAUDI NIC code to habanalabs driver
From: Greg Kroah-Hartman
Date: Sat Sep 19 2020 - 02:40:26 EST
On Fri, Sep 18, 2020 at 03:19:05PM +0300, Leon Romanovsky wrote:
> > So we do have an open-source library called hl-thunk, which uses our
> > driver and indeed that was part of the requirement.
> > It is similar to libdrm.
> > Here is the link:
> > https://github.com/HabanaAI/hl-thunk
> Are you kidding?
> This is mirror of some internal repository that looks like dumpster
> with ChangeId, internal bug tracker numbers, not part of major OS
> It is not open-source library and shows very clear why you chose
> to upstream your driver through driver/misc/ tree.
It is an open source library, as per the license and the code
availability. What more is expected here?
No distro has to pick it up, that's not a requirement for kernel code,
we have many kernel helper programs that are not in distros. Heck, udev
took a long time to get into distros, does that mean the kernel side of
that interface should never have been merged?
I don't understand your complaint here, it's not our place to judge the
code quality of userspace libraries, otherwise we would never get any
real-work done :)