Re: [PATCH 1/4] x86: add __X32_COND_SYSCALL() macro
From: Andy Lutomirski
Date: Sat Sep 19 2020 - 12:23:38 EST
On Fri, Sep 18, 2020 at 10:35 PM Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote:
> On Fri, Sep 18, 2020 at 03:24:36PM +0200, Arnd Bergmann wrote:
> > sys_move_pages() is an optional syscall, and once we remove
> > the compat version of it in favor of the native one with an
> > in_compat_syscall() check, the x32 syscall table refers to
> > a __x32_sys_move_pages symbol that may not exist when the
> > syscall is disabled.
> > Change the COND_SYSCALL() definition on x86 to also include
> > the redirection for x32.
> > Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> Adding the x86 maintainers and Brian Gerst. Brian proposed another
> problem to the mess that most of the compat syscall handlers used by
> x32 here:
> hpa didn't particularly like it, but with your and my pending series
> we'll soon use more native than compat syscalls for x32, so something
> will need to change..
I'm fine with either solution.