Re: [PATCH] ARM: dts: am335x: guardian: switch to AM33XX_PADCONF

From: Drew Fustini
Date: Mon Sep 21 2020 - 05:59:18 EST

On Mon, Sep 21, 2020 at 09:47:07AM +0300, Tony Lindgren wrote:
> * Drew Fustini <drew@xxxxxxxxxxxxxxx> [200919 19:53]:
> > Change the pin defintions from AM33XX_IOPAD to AM33XX_PADCONF macro so
> > that it correctly handles changes to #pinctrl-cells.
> Thanks for fixing this. I wonder if we should now also change the define
> for the old AM33XX_IOPAD macro?
> Or just remove it completely and mention that we've changed nr-pinctrl-cells
> to use 3 now?
> Otherwise the unknown number of out-of-tree boards will be hitting this
> too.

Christina Quast commented in f1ff9be7652b ("ARM: dts: am33xx: Added
AM33XX_PADCONF macro") that AM33XX_IOPAD() was left in place to avoid
breaking boards not in mainline.

If we follow that logic, then I think that fixing AM33XX_IOPAD() for
#pinctrl-cells = <2> would be the correct solution.

Would this be acceptable?

#define AM33XX_IOPAD(pa, val) OMAP_IOPAD_OFFSET((pa), 0x0800) (val) (0)