Re: [PATCH v38 12/24] x86/sgx: Add SGX_IOC_ENCLAVE_CREATE

[Borislav Petkov]

On Mon, Sep 21, 2020 at 03:28:23PM +0300, Jarkko Sakkinen wrote:
> Is this appropriate:
> 
> 	/* The extra page in swap space goes to SECS. */
> 	encl_size = secs->size + PAGE_SIZE;
> 
> 	backing = shmem_file_setup("SGX backing", encl_size + (encl_size >> 5),
> 				   VM_NORESERVE);
> 	if (IS_ERR(backing)) {
> 		ret = PTR_ERR(backing);
> 		goto err_out_shrink;
> 	}
>

Yap, thanks.

> I agree with this but I also think it would make sense to rephrase
> "verifying the correctness of the provided SECS" with something more
> informative.
> 
> I would rephrase as:
> 
> "... after checking that the provided data for SECS meets the expectations
> of ENCLS[ECREATE] for an unitialized enclave and size of the address
> space does not surpass the platform expectations. This validation is
> executed by sgx_validate_secs()."

s/executed/done/

> Is this sufficient for you, or do you have further suggestions?

Yes, no further suggestions.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette