On Fri, Sep 18, 2020 at 11:42:54AM +0800, Reddy, MallikarjunaX wrote:ok, i will change bool to tristate.
On 9/9/2020 7:14 PM, Andy Shevchenko wrote:...
On Wed, Sep 09, 2020 at 07:07:34AM +0800, Amireddy Mallikarjuna reddy wrote:
I'm expecting to see something like "if you choose M the module will be calledare you expecting to include 'default y' ?+ helpAnd how module will be called?
+ Enable support for intel Lightning Mountain SOC DMA controllers.
+ These controllers provide DMA capabilities for a variety of on-chip
+ devices such as SSC, HSNAND and GSWIP.
bla-foo-bar." Look at the existing examples in the kernel.
How comes these are constants? In the above you have a function which does- new_val = (old_val & ~mask) | (val & mask);+ldma_update_bits(struct ldma_dev *d, u32 mask, u32 val, u32 ofs)With bitfield.h you will have this as u32_replace_bits().
+ u32 old_val, new_val;
+ old_val = readl(d->base + ofs);
+ new_val = (old_val & ~mask) | (val & mask);
+ new_val = old_val;
+ u32_replace_bits(new_val, val, mask);
I think in this function we cant use this because of compilation issues
thrown by bitfield.h . Expecting 2nd and 3rd arguments as constant numbers
not as type variables.
u32_replace_bits(val, 0, IPA_REG_ENDP_ROUTER_HASH_MSK_ALL);
r-m-w approach to the register. It should be something like
old = read();
new = u32_replace_bits(old, ...);
./include/linux/bitfield.h:131:3: error: call to '__field_overflow' declaredSo, even with constants u32_replace_bits() must work. Maybe you didn't get how?
with attribute error: value doesn't fit into mask
./include/linux/bitfield.h:119:3: error: call to '__bad_mask' declared with
attribute error: bad bitfield mask
ok....+ if (new_val != old_val)
+ writel(new_val, d->base + ofs);
Make it clear in the comment.this is higher 4 bits of 36 bit addressing..+ /* High 4 bits */Why only 4?
/*ok. is it fine?+device_initcall(intel_ldma_init);Each _initcall() in general should be explained.
/* Perform this driver as device_initcall to make sure initialization
* before its dma clients of some are platform specific. make sure to
* registered dma channels and dma capabilities to client before their
* Just follow proper multi-line comment style.
* And use dma -> DMA.