Re: [PATCH 2/5] fs,nfs: lift compat nfs4 mount data handling into the nfs code

From: Christoph Hellwig
Date: Mon Sep 21 2020 - 14:11:28 EST


On Mon, Sep 21, 2020 at 12:05:52PM -0400, Anna Schumaker wrote:
> This is for the binary mount stuff? That was already legacy code when
> I first started, and mount uses text options now. My preference is for
> keeping it as close to the original code as possible.

Ok. Al, are you fine with the series as-is then?

>
> I'm curious if you've been able to test this? I'm not sure if there is
> a way to force binary mount data through mount.nfs

The test is pretty trivial - even the most recent nfsutils supports the
binary mount data. You just need to patch out the detection for a
modern kernel.