Re: [PATCH v38 15/24] x86/sgx: Enable provisioning for remote attestation

From: Jarkko Sakkinen
Date: Mon Sep 21 2020 - 17:26:49 EST


On Mon, Sep 21, 2020 at 09:41:56PM +0200, Borislav Petkov wrote:
> On Mon, Sep 21, 2020 at 10:27:06PM +0300, Jarkko Sakkinen wrote:
> > 'sgx_dev_enclave' is successfully register whenever that happens. Am I
> > missing something here?
>
> No, I was missing the fact that you have *two* misc devices and you're
> deregistering the first one in the error path of the second.
>
> Forget what I said. ;-\

Ok, great.

BTW, probably would make sense to rewrite the short summary as:

"x86/sgx: Add SGX_IOC_ENCLAVE_PROVISION"

for the sake of consistency with the three precursoring patches.

> --
> Regards/Gruss,
> Boris.
>
> https://people.kernel.org/tglx/notes-about-netiquette

/Jarkko