Re: [PATCH] net: unix: remove redundant assignment to variable 'err'
From: David Miller
Date: Mon Sep 21 2020 - 17:52:03 EST
From: Jing Xiangfeng <jingxiangfeng@xxxxxxxxxx>
Date: Mon, 21 Sep 2020 11:29:52 +0800
> After commit 37ab4fa7844a ("net: unix: allow bind to fail on mutex lock"),
> the assignment to err is redundant. So remove it.
>
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@xxxxxxxxxx>
...
> @@ -878,7 +878,6 @@ static int unix_autobind(struct socket *sock)
> if (err)
> return err;
>
> - err = 0;
> if (u->addr)
> goto out;
Yes, err is always zero here in this code path.
Applied, thanks.