Re: [PATCH v2 31/32] auxdisplay: charlcd: Do not print chars at end of line

From: Willy Tarreau
Date: Tue Sep 22 2020 - 01:36:53 EST


On Mon, Sep 21, 2020 at 04:46:43PM +0200, poeschel@xxxxxxxxxxx wrote:
> From: Lars Poeschel <poeschel@xxxxxxxxxxx>
>
> Skip printing characters at the end of a display line. This fits to the
> behaviour we already had, that the cursor is nailed to last position of
> a line.

Just very old memories, but wasn't this used with the ability to shift
the display ? IIRC the HD44780 has a 2x64 chars buffer and you can make
the buffered characters appear when you shift the display. That's akin
to seeing the display as an adjustable window over the buffer. I don't
remember having used that feature, so if it didn't previously work, please
disregard my comment, I just want to be sure we don't break a feature
others might be relying on.

Willy